Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@react-icons/all-files hasn't been updated in long time. Replace it with react-icons #642

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

@react-icons/all-files hasn't been updated in long time. Replace it with react-icons #642

wants to merge 2 commits into from

Conversation

onnimonni
Copy link
Contributor

@onnimonni onnimonni commented Nov 1, 2024 •
edited
Loading

Context

This fixes the annoying DeprecationWarning and should allow us to use all of the new icons which are not available in @react-icons/all-files.

$ pnpm dev

> [email protected] dev /Users/onnimonni/Projects/nextjs-notion-starter-kit
> next dev

   ▲ Next.js 15.0.2
   - Local:        http://localhost:3000

 ✓ Starting...
 ✓ Ready in 3.2s
 ○ Compiling / ...
 ✓ Compiled / in 1286ms (759 modules)
(node:79829) [DEP0128] DeprecationWarning: Invalid 'main' field in '/Users/onnimonni/Projects/nextjs-notion-starter-kit/node_modules/@react-icons/all-files/package.json' of 'lib'. Please either fix that or report it to the module author
(Use `node --trace-deprecation ...` to show where the warning was created)

Screenshots

Icons are rendering perfectly even after this change:
image

@vercel Vercel
Copy link

vercel bot commented Nov 1, 2024

@onnimonni is attempting to deploy a commit to the Saasify Team on Vercel.

A member of the Team first needs to authorize it.

@socket-security Socket Security
Copy link

socket-security bot commented Nov 1, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@react-icons/[email protected]

View full report↗︎

This was referenced Nov 1, 2024
Open
Open
Open
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@onnimonni